Jason Marshall

Results 294 comments of Jason Marshall

For now I set my gh actions to use 24.6, which won't bother anyone for a few weeks. Since it only happens to me in tests I'm debating whether I...

> I have a script that blocks the event loop and is run with a timeout: // in loop.js while(true) {} You understand why this can never work?

You cannot receive a signal in Nodejs while the event loop is unresponsive. The event generated by the signal will be processed only the next time the event loop becomes...

``` const require = Module.createRequire(import.meta.url); ``` Should take care of our `loadFile` workflows.

If you're willing to file a PR, I'm willing to work on loren and mark.

I discovered this morning that Chai is currently struggling with addon support and ESM modules. This is not something I’d encountered before, but apparently modifying the exports of an ESM...

I got what I thought was 90% through reworking the code but not the tests into ESM and then I got stuck. Because it seems that when you loop through...

Similar problem to #740

I'm going to declare this a special case of #740, as any solution that fixes this issue would be best served by also addressing that one.

This should fix #628 A lot of the gain here is that `keyFrom` is roughly 2x as fast as `hashObject`. But the shorter key also makes the Map a little...