Jason Marshall
Jason Marshall
I just touched this code. #669 so it's front-of-mind this.observe has different input costraints than observe. I was tempted to change the name collision but opted not to. Also tempted...
There's not much internal state in any of these functions. Is there any reason not to make them protected methods on Histogram or move them to another file perhaps?
@fermeaux #669 has merged. Does this help you?
This could perhaps be fixed by delaying: message.metrics.forEach(metric => request.responses.push(metric)); request.pending--; and instead do a Promise.all() against all n results an concatenates the results after they are all received instead...
I have a PR cooking for Worker support and I’m worried about propagating this error. I think maybe changing the logic to return a promise per worker might be better....
I added this package to the benchmark code in #680 but only as a dev dependency
@vitush93 see #692
I believe this is fundamentally the wrong solution. - You cannot fire a timeout event unless the event loop is unblocked. So you cannot abort out of a tight loop...
There's a workaround that works in node 24, `--test-isolation none`, but this flag doesn't exist in node 20, which means that the common github pattern of running your module on...
Coincidentally my test case also uses —expose-gc but it didn’t get far enough to fail. It’s in one of Rafael’s projects so 🤞 @u873838 can you verify the last good...