Jason Marshall

Results 294 comments of Jason Marshall

Sure. Are you running different eslint settings that “test”? Thought I already caught these.

> $ npm run lint > > > [email protected] lint > > eslint . > > ============= > > WARNING: You are currently running a version of TypeScript which is...

Well that one was just sloppiness. Fixed.

Coverage % drops slightly because this removed covered code from a file that has some uncovered functions in it. Probably should fix that in 4.0.x

There is default label support in the registry, which you can add each metric to. https://github.com/siimon/prom-client/blob/4c6421b2253c9780a845889004b9a58dac646a1c/lib/registry.js#L17 Given the number of open tickets about memory and CPU pressure, and how much...

I'd like us to sort out the setModuleDefaults issue. I think I may have a solution we could to in Util to keep the defaults and the loaded config as...

this conflicts a bit with a PR for #822 which also happens to fix this one.

Lockfiles are pretty much required for applications. For libraries however, they tend to be anywhere on a spectrum from 'less useful' to 'obstructive'. You really need a monorepo as well...

Don’t do this. Do: ``` feeAccountBallance.set(feeAccount.balance, { type: feeAccount.type } ); ``` Prometheus and OTEL generally don’t do stat differentiation by string interpolation. It’s a pain in the butt to...