Jason Marshall comments

Results 294 comments of


                                            Jason Marshall

perf: fix for cluster aggregation performance

So after staring at this code for the better part of a week, and spending a good bit of time at my previous job trying to write something like this...

perf: fix for cluster aggregation performance

https://github.com/siimon/prom-client/pull/692 answers most of these concerns. The main thing I have not done is recycling the per-stat collectors between aggregation calls. There are functions which support it, but I'm not...

🐛 Bug: Mocha's integration tests fail locally, and then tests won't run at all afterward

The tests that fail seem to be consistent. On macOS Sonoma 14.7.4 (23H420)

🐛 Bug: Mocha's integration tests fail locally, and then tests won't run at all afterward

@JoshuaKGoldberg Now they fail for a completely different reason. How are you guys running the tests? I'm baffled why the PR builds are succeeding. ```plaintext 1) root hooks when mocha...

🐛 Bug: Mocha's integration tests fail locally, and then tests won't run at all afterward

Same. On Mac if that matters. What version of node?

🐛 Bug: Mocha's integration tests fail locally, and then tests won't run at all afterward

This is weird. I don’t think I have anything installed globally (and use nvm anyway)

Fix parsing error in Elixir 1.15

I could not figure out how to clear SSL related errors locally. Seems like there is only docs for using, not building this module.

Coverage % alternates from one run to another

What’s going on with lines 10, 14, 15, 25? Timing issues perhaps?

perf: Utilize Maps for metric collection

This still works on node 16. It’s just that the numbers are less impressive.

perf: Utilize Maps for metric collection

I got warnings about a CI error as email, but I'm not seeing them here in the PR. Shouldn't they be listed here as well?