Jon Robson
Jon Robson
@mary-kate
@mary-kate did you want to get the skin into Gerrit first before applying this patch or is doing it here first okay?
Duplicate of #24. Will investigate.
I think copying over the methods makes a lot of sense. As for < 1.36 support I can test and let you know. https://skins-demo.wmflabs.org/wiki/Special:Version?useskin=cavendish is running latest version, so I'll...
Would a patch be welcome to fix this up provided it doesn't break 1.35 compatibility?
@borkweb is this skin still maintained?
I hit this one recently! It was a barrier for entry for someone (And for an inexperienced me!) who I was introducing to it. A one click button would be...
Hosting on Wikimedia Gerrit would be ideal, but Wikimedia github would also work!
Update: The styles associated with the legacy feature was just removed as part of https://phabricator.wikimedia.org/T304325 https://www.mediawiki.org/wiki/Manual:ResourceLoaderSkinModule#For_skins_deprecating_the_legacy_feature has some guidelines on what to do.
Note in 1.39 all styles associated with legacy have been removed. You'll likely want to patch this as part of 1.39.