Jason Desrosiers
Jason Desrosiers
Looks like a good start! Thanks for moving this forward.
> Bug 1: Homepage crash when blogPosts is empty `blogPosts` will never be empty. Please consider the whether the changes you're proposing are practical and solving a real problem.
This should have been opened as [draft PR](https://github.blog/news-insights/product-news/introducing-draft-pull-requests/). I've converted it this time. Next time you open a PR that's a work in progress for the purpose of getting feedback,...
If `@hyperjump/json-schema` is useful for supporting 2020-12, let me know. I'd be happy to help if I can.
> By allowing these, are we saying that all historical schemas are valid v1 schemas that just use different dialects, e.g. a draft 6 dialect? That definitely doesn't sound right....
> While I agree that your example of a scheduled job doesn't make much sense, what if we're checking the timestamp of an event? That might be worth supporting. A...
I strongly disagree that it's not ambiguous. But, I'm convinced that this isn't a test repo issue. Allowing leap seconds is at least a reasonable interpretation of the spec. Since...
Leaving aside the debate about how the `time` format should be interpreted for the current release, we need to make a decision on what the intended interpretation will be for...
> I don't think it is ambiguous - it is just "not the common sense understanding". Times are allowed to include leap seconds. Divorced from the context of a date,...
If there's no objections, I'm going to add a clarification that `time` doesn't have leap seconds citing the language that @gregsdennis quoted.