John Blischak

Results 282 comments of John Blischak

Quick update. The main motivation for submitting this recipe to bioconda was the htslib dependency. However, in order to build conda binaries for the latest release (0.21.0, https://github.com/TileDB-Inc/tiledb-vcf-feedstock/pull/62), we had...

Another update. A big benefit of submitting to bioconda is that it automatically creates biocontainers (ie Docker images with the single tool installed). These biocontainers are [strongly preferred by nf-core](https://nf-co.re/docs/contributing/guidelines#recommendations)...

Another twist: building htslib as part of the superbuild was laborious. Building for all the variants of libdeflate and openssl required many builds (https://github.com/TileDB-Inc/tiledb-vcf-feedstock/pull/70; purely for the sake of htslib),...

I can reproduce the solver error. The problem is because we build libtiledbvcf against the latest htslib created by [TileDB-Inc/htslib-feedstock](https://github.com/TileDB-Inc/htslib-feedstock), which is still at 1.16. Because of the [run exports...

I've created a new Issue to track updating the htslib version linked to libtiledbvcf https://github.com/TileDB-Inc/tiledb-vcf-feedstock/issues/106

> It finds that windows-2022 is missing redistributable 14.38.33130 as required by conda-forge. > > Similar issue is to be filed for conda-forge/vc-feedstock maintainers to see whether that version can...

> Why are we adding `TILEDB_PATH` here rather than just using `TileDB_DIR`? @ihnorton I believe that was at my request. I would like to keep the build configuration options for...

> Isn't that only an environment variable, not a CMake variable? Yes, good point. I only care about the name of the env var, not the CMake variable

Thanks for working on this @dudoslav! I apologize for my delay in reviewing this PR. I did some local testing. Within a conda environment, it works as I expected. However,...

> right now a path to TileDBConfig.cmake is needed this works My proposal would be the following: * `TILEDB_PATH` is the path to the installation directory. For a conda env...