Jelle Assink

icon indicating a website link https://www.knmi.nl/over-het-knmi/onze-mensen/jelle-assink

icon company Royal Netherlands Meteorological Institute (KNMI) icon location De Bilt, The Netherlands icon location I am a geophysicist with the Seismology and Acoustics department at the Royal Netherlands Meteorological Institute (KNMI).

Results 3 comments of Jelle Assink

Sc3ml response

> I can see the usefulness of this PR @jdassink 👍, but it will need some changes, see comments. > > It will also need a changelog entry and we'll...

Sc3ml response

> Two things left: > > * clean up flake8 (see `lint_code` CI action) > * test the warning message being shown, see e.g. [here](https://github.com/obspy/obspy/blob/79558d2169e1f63b9f73d60d48f383d497c6ffb0/obspy/io/xseed/tests/test_core.py#L567-L574) using our helper context manager...

Sc3ml response

> > What exactly do you mean with the second bullet point? Should I adjust the `test_inventory.py`? > > Ideally, you should add a test in `test_inventory.py` which does a...