John-David Dalton

Results 381 comments of John-David Dalton

In bun if I do: ```js import { expect, test } from 'bun:test'; test('woo', () => { expect([-0]).toEqual([-0]) // pass }); ``` but ```js expect([0]).toEqual([-0]) // fail ``` So bun...

Closing as covered by https://github.com/package-url/packageurl-js/pull/71

[v2.0.0](https://www.npmjs.com/package/packageurl-js/v/2.0.0) has been published 🎉

If you `.toString()` it then it's encoded: ```js p.PackageURL.fromString('pkg:maven/org.apache.commons:[email protected]').toString() // => 'pkg:maven/org.apache.commons%[email protected]' ```

The exact maven examples fails on master branch with: ``` Error Invalid purl: maven requires a "namespace" field. ``` If adding a namespace/name: ```js PackageURL.fromString('pkg:maven/org.apache.commons:io/[email protected]') ``` will still allow it...

@surendrapathak I typo'd the example 🤦 . It was supposed to be: ```js PackageURL.fromString('pkg:maven/org.apache.commons:io/[email protected]') PackageURL.fromString('pkg:maven/org.apache.commons%3Aio/[email protected]') ``` with the namespace as master branch will throw an error for maven purls without...

@surendrapathak Yay! [v2.0.0](https://www.npmjs.com/package/packageurl-js/v/2.0.0) ftw 🎉

Cannot reproduce bug given the example above: https://github.com/package-url/packageurl-js/pull/62#issuecomment-2115067509

Ah, my bad. @matt-phylum you are correct.