John-David Dalton

icon indicating a website link https://bsky.app/profile/jddalton.bsky.social

icon company Socket.dev icon location Remote icon location Lodash creator • sometimes TC39 delegate • protecting supply chains at https://Socket.dev • Ex (Bun, Salesforce, Node core, Electron WG, Microsoft)

Results 388 comments of John-David Dalton

Invalid purl: version must be percent-encoded

This is fixed on master branch.

Invalid purl: version must be percent-encoded

@kennylam91 > will it be rolled out soon? I don't control that but after the next batch of patches lands I'll inquire!

Invalid purl: version must be percent-encoded

[v2.0.0](https://www.npmjs.com/package/packageurl-js/v/2.0.0) has been published 🎉

purl containing a query parameter repository_url with own (encoded) query parameters not handled correctly?

Related to https://github.com/package-url/purl-spec/issues/39

purl containing a query parameter repository_url with own (encoded) query parameters not handled correctly?

This is handled in https://github.com/package-url/packageurl-js/pull/73 by using `URLSearchParams` to encode and then turning `+` into `%20` for better portability. I sided with the [Rust implementation](https://github.com/package-url/packageurl.rs/commit/2d6489bda6261450d0ed884e0ba1065837c1f0f0). Also leveraging standard `URLSearchParams`. Deferring...

purl containing a query parameter repository_url with own (encoded) query parameters not handled correctly?

Closed by #73

Incorrect validation of version encoding

Fixed in master branch (both `2%2B3` and `2+3` work)

Package types are case sensitive

@matt-phylum I see you've opened a few issues. Thank you! Do you have bandwidth for opening PRs too? That would be helpful.

Package types are case sensitive

Fixed in master branch.

Package types are case sensitive

[v2.0.0](https://www.npmjs.com/package/packageurl-js/v/2.0.0) has been published 🎉