Results 1568 comments of John Cupitt

Ooof, it's been a couple of years since I looked at this, I remember it was hard to get chroma subsampling to work. I've read the libvips jp2k load and...

It'd be good to test the libvips chromasubsample mode against another implementation. I think we'd probably need to get a license for one of the commercial jp2k systems and see...

... libvips 8.14 defaults jp2k save to chroma subsample off.

Oh, interesting. We've gone back and forth on mct a few times, it was most recently disabled if subsampling is on. https://github.com/libvips/libvips/commit/57d8dd3ecee292f8e2928ae4a9a0282a9b300655 Of course I intelligently didn't make a note...

Huh hmmm I'm not sure either now. The openjpeg docs are rather opaque :( I didn't realize `mct` meant "enable RGB -> YCC conversion" until you said (if indeed that's...

That sounds reasonable. I'll make a PR with a proposed revision we can test. Thanks for doing this research @felixbuenemann ! (or would you rather make a PR? I don't...

I tried under linux and it runs cleanly on Ubuntu 18.04 under valgrind using orc 0.4.28. I tried 100 iterations, and that worked too. I'll try on the mac later....

Argh I can't get lldb to pick up any debugging info. I see: ``` john@katamata:~/try$ lldb a.out (lldb) target create "a.out" Current executable set to 'a.out' (x86_64). (lldb) run Process...

Of course I had an old and dead libvips in `/usr/local` sigh. lldb is working now. It looks like a race and a double-free triggering heap corruption. I'm trying to...