Results 1568 comments of John Cupitt

Hi, that's an interesting decompression bomb. I see: ``` $ ls -l lottapixel.jpg -rw-rw-r-- 1 john john 4856 Jan 14 13:10 lottapixel.jpg $ vipsheader -a lottapixel.jpg lottapixel.jpg: 64250x64250 uchar, 3...

> 2. Since VIPS giving the above warnings that means it is a known condition, Should it not be treated as error instead of just warning? libvips is permissive by...

> Sure, I will open the same on libvips also. I don't think there's anything more libvips can do here, so there's no need for an issue.

Oh, nice! I don't know Go, can this overflow? ```go if (config.Width * config.Height) > (bimg.MaxSize * bimg.MaxSize) { ``` It might be better as a double float multiply..

Hello, this should be fixed by https://github.com/jcupitt/libvips/issues/639 , which is released as libvips 8.5.4. I'm sorry this has been causing problems. There's a new thing in the test suite which...

@willtrking oh dear, then I guess it's a problem in the bimg layer. Could it be auto-rotate? You need to render via a memory buffer for this. There's a page...

Hi again, libvips is being used at very high levels of concurrency without issue in several other projects, so while it could be a libvips issue I suspect it is...

8.9.1 has a couple of races fixed, it'd be worth trying that if you're not on it.

I had a quick look at the bimg source. This seems to be the line handling auto-rotate: https://github.com/h2non/bimg/blob/master/resizer.go#L38 It's doing it at the start of processing, which is probably not...

`vips_thumbnail_image()` can't exploit shrink on load (since the image has already been loaded). If you can, use `vips_thumbnail_buffer()` instead, it should be much quicker.