Results 1568 comments of John Cupitt

Ah shame. I think that's all we can do with photoshop compat, without a lot of work. Roundtripping through CIELAB is easy, just: ``` $ vips icc_export theo-kickbike.jpg x.v --output-profile...

I just commented out the bits of the libvips TIFF writer that wrote the tags photoshop seemed to dislike. These changes are not part of this PR, they'd need more...

I think it was just this: ```diff diff --git a/libvips/foreign/vips2tiff.c b/libvips/foreign/vips2tiff.c index 058cece76..876a43d03 100644 --- a/libvips/foreign/vips2tiff.c +++ b/libvips/foreign/vips2tiff.c @@ -602,6 +602,8 @@ wtiff_embed_photoshop( Wtiff *wtiff, TIFF *tif ) static int...

Let's merge this work and try to improve the tiff writer tags in another PR. Please open a new issue if there are any problems.

Hi, I'll have a look. I expect you saw you can use `--force` to make it break aspect ratio. It might fix your immediate problem.

I think this is down to differences in shrink on load behaviour between the file format libraries. Your ruby code is using `thumbnail_image`, which does not use any shrink on...

Wow, I'm amazed text worked for such large strings! A separate path for mono rendering sounds bad in terms of maintenance, but I agree it'd fix this issue. Would it...

Oh, good idea. The kill flag is checked in the thing that loops down the image, but of course that's only checked once per line of tiles. It could maybe...

Hi @karray, You're right, these values are sanity checked in the tiffsave API to be > 0.001. I'll change it, thanks for reporting this issue. As a workaround, you can...

Huh you're right, the tiff saver also clips the resolution: ```C /* Don't write mad resolutions (eg. zero), it confuses some programs. */ TIFFSetField( tif, TIFFTAG_RESOLUTIONUNIT, wtiff->resunit ); TIFFSetField( tif,...