Jakub T. Jankiewicz comments

Results 1194 comments of


                                            Jakub T. Jankiewicz

trafficstars

fix: isPromiseFs out-of-spec usage of readFile

It fails for Android, the the code touched is always executed so the error came from that code. Can you try changing it to an empty string?

fix: isPromiseFs out-of-spec usage of readFile

The last PR was this one [#1853](https://github.com/isomorphic-git/isomorphic-git/pull/1853) and the test was passing. I will try to create a trivial PR to test if the tests pass.

fix: isPromiseFs out-of-spec usage of readFile

The tests are broken, I have no idea why. Here is a README change #1858 that is also failing. I will merge this PR when I fix the tests, never...

fix: isPromiseFs out-of-spec usage of readFile

The tests got fixed, please rebase.

How to add own HTML and specify setAutoHideAnimation property

:+1:

Git.readBlob is too slow.

I don't think that we can do anything to make it faster. This is the limitation of NodeJS and FS. NodeGit uses libgit library that is written in C, that's...

Maintained fork

@smuuf I've found a few issues with your fork but no way to report a bug. There is an issue with quotation characters, they work only in regular expressions. There...

implement cherry-pick

First of all the tests didn't pass, you have Lint errors. Fix lint errors so we can see if the tests pass. They are executed with `&&` in one line.

implement cherry-pick

Thanks for your contribution, I need to check the code locally how the function works on real repo.

implement cherry-pick

Do you really need those options: ``` ours: 'a', theirs: 'd7676dfe102cd28ec794b25f9a6231af0cdfd16d', ``` Can you just name them `oid` and `branch` like in other API methods?