Jorge Creixell

Results 24 comments of Jorge Creixell

@mattdurham I have addressed your comments, please have another look when you have time. The only remaining issue I can think of is that both flow and non-flow metrics are...

@mattdurham See my last commit for a refactoring moving the duplicated code into a new package. I tried the simple solution of manually registering the metrics during execution, but it...

@grafana/grafana-agent-maintainers I think I am done here, feel free to merge if you are ok with my last commits and comment

@quodlibetor thank you for reporting this issue. We have been able to reproduce it. It seems related to a known issue in loki's promtail when fetching target details. See https://github.com/grafana/loki/issues/6930....

@rgeyer thanks for reporting this. Fixing this at this point would be a breaking change, and given that Flow does not have this problem, we will close this for now.

I think we should use functions to generate a new copy of the default config instead of keeping a global copy. I have seen many outages caused by this (for...

I tested [this](https://github.com/grafana/prometheus/compare/7238d25101e58fc9fd77b339d61f6d5f0abb5760...f19659f924e39d105a4e0127efe37d11e29d9106) and can confirm that it makes errors show up in logs. Agreed that this needs to be fixed upstream.