Pat Riehecky

Results 259 comments of Pat Riehecky

I think the test failures look related @trevor-vaughan can you help?

Can you rebase off head for the CI?

Can you add some unit tests to this? Here is an example commit with some testing : https://github.com/voxpupuli/puppet-firewalld/commit/55ed8abed9293fdaacb817380891afcc9044c987

I'm showing https://github.com/voxpupuli/puppet-firewalld/blob/master/metadata.json#L65 for the next release of puppet-firewalld

Is this still viable? I'd love to have it in if so....

Just checking back in.

I've used the "full" fact twice since I wrote it. Once to fine the systems using dropped kmods for migrating to EL8 and once for the same thing for EL9....

Any idea why the tests are failing?

I currently set a message if `needs-restarting` shows a reboot or if services are pending a restart. For `tracer` to be a true replacement, I'll need some sort of way...