puppet-firewalld icon indicating copy to clipboard operation
puppet-firewalld copied to clipboard

Pass the protocols to custom_service

Open jovandeginste opened this issue 2 years ago • 1 comments

Pull Request (PR) description

This allows you to specify protocols in through firewalld::custom_service, which are then passed on to firewalld_custom_service.

Signed-off-by: Jo Vandeginste [email protected]

jovandeginste avatar Jan 09 '23 11:01 jovandeginste

Can you add some unit tests to this?

Here is an example commit with some testing : https://github.com/voxpupuli/puppet-firewalld/commit/55ed8abed9293fdaacb817380891afcc9044c987

jcpunk avatar Jan 25 '23 19:01 jcpunk