Jérémie Corbier

Hi, It looks like there is a bug in the retain closure when filtering out entities that would overlap with a room vault: https://github.com/amethyst/rustrogueliketutorial/blob/33872fe582f226178436847e1f74eafcbf9c0d1a/chapter-35-vaults2/src/map_builders/prefab_builder/mod.rs#L385 I believe this should be: ```rust...

[xilpki] Potential incorrect command descriptor for P384 private key generation

3

Hi, At [line 98](https://github.com/Xilinx/embeddedsw/blob/3728f546f178a1bcd91cf6efc9f8921447846cec/lib/sw_services/xilpki/src/xilpki.c#L98C55-L98C55) in xilpki.c: ``` #define PKI_ECC_NIST_P192_KEY_PRIV_GEN_CMD 0x00001701U #define PKI_ECC_NIST_P256_KEY_PRIV_GEN_CMD 0x00001F01U #define PKI_ECC_NIST_P384_KEY_PRIV_GEN_CMD 0x00002F02U #define PKI_ECC_NIST_P521_KEY_PRIV_GEN_CMD 0x00004101U ``` Shouldn't `PKI_ECC_NIST_P384_KEY_PRIV_GEN_CMD` be using the same 0x01 operation ID as...