Jude Nelson

Results 548 comments of Jude Nelson

> The arguably "better" alternative would of course be protobuf The arguably "better" alternative is to just bite the bullet and use `StacksMessageCodec` for all the things we currently use...

Sure, those are all fair points, and I agree on the top-level bit that we should distinguish between data structures that have consensus-critical byte representations (begetting consensus-critical codecs) and those...

Assigning this to @netrome so it has an owner. Also, I don't think this is consensus-critical; we just store the data in the sortition DB but don't make any decisions...

Also, yes -- feel free to remove `StagingUserBurnSupport`. As long as CI passes, it should be fine.

@hstove I'm personally fine with either approach. However, if you add this to the SIP, you should expect some pushback because creating unspendable witness UTXOs constitutes "UTXO pollution" (which I...

One last thing - I just saw that this is based against `develop`. It should be based against `next` since that's where Nakamoto development is happening.

Otherwise LGTM. I'll approve once it's based on `next`.

This is nowhere close to being ready. First, adding a new mode of transaction authorization requires a hard fork, with gating logic to ensure that any transaction with this new...

> Your second point about signatures being equal from different owners is a bit hard to imagine now, could you elaborate on that? Do you mean when Alice signs the...

Your code allows `MultisigSpendingCondition::verify()` to change the order in which public keys are hashed. But it does not ensure that the recovered public keys are actually the signers' public keys....