Jude Nelson

Results 548 comments of Jude Nelson

One caveat is that the event observer could fall behind the node, and cause the `event_observers.sqlite` DB to grow unbounded. How do you imagine that we'd address this?

> Bitmap flag (aka 0xff): Could we use a bit of the Node ID to indicate whether a bitmap is present? This could save one byte per node and rely...

Alright, all CI tests pass @federico-stacks

@federico-stacks Please, do not force-push changes. It makes it very difficult to see what has changed in-between reviews. Instead, please merge the two branches and create a merge commit. Thanks!

The inner `String` is just to be an informative message. I don't think there are any consensus-critical code branches that depend on the message contents.

To elaborate more on this, the implementation will look as follows: * Every `struct` that has a `FromRow` or a `FromColumn` implementation that encodes or decodes the data as a...

In addition to `FromRow` and `FromColumn` structs, we should handle the following structs specially, since they contain lots of binary data but are not serialized as hex strings. Instead, I'll...

Discoveries so far: * Not storing the `back_block` field in a `TriePtr` for non-backptr nodes saves 10-15% of space in tests. This value is always `0` for non-backptr nodes *...

More discoveries: * Compressing sparse lists of `TriePtr` (whose contents are largely empty pointers) produces another 5-10% space savings. We instead store a bitmap of which `TriePtr` slots are non-empty,...

@brice-stacks Since the reversion to libsecp256k1 is complete, can this be closed?