Joseph Brill

Results 203 comments of Joseph Brill

> So it avoids adding an explicit dep. Isn't that kind of what we're seeing? It sure looks that way but I can't be certain. I feel like I've read...

> And since we're the ones supplying the command line, how do we tell? I haven't the foggiest idea (yet). I tried a handful of ways to manually add a...

If the `PCH` variables are defined following the `StaticLibrary` call (i.e., after the source files have been registered) the build succeeds. I'm not saying this is a good idea and...

For the Windows workflow run, test `test\MSVC\msvc.py` fails due to the precompiled headers speed test. In #4534, I removed the multiplier (i.e., effectively 1.0): ```diff # TODO: Reevaluate if having...

> The pkg-config test fails because perl is not found, but it's also not used !?!?!? And don't know where it found that path for pkg-config, it should be unable...

The following could be wrong... > I still don't know why perl gets involved. The `where-is` call is returning the fully qualified path to the Strawberry Perl batch file `pkg-config.bat`....

It may be helpful to review the following documentation changes before reviewing the code changes: * *SCons\\Tool\\MSCommon\\README.rst* * *SCons\\Tool\\msvc.xml* The following source code files contain the bulk of the code...

Future work: * Modifications to support v143 toolsets 14.4X.YYYYY * Support for preview versions Depending on the manner in which support for preview versions is implemented, it may be possible...

> In the email notification I see it is setting that to black: ${\tt{\normalsize{\color{black}\text{detect, vswhere}}}}$. Any possibility to tweak that? Removed the color assignment (${\tt{\normalsize{\text{detect, vswhere}}}}$). Is there a difference?...

> Yes, it's fine. It was only a minor nit - thanks! I appreciate the feedback. For something unrelated a couple of weeks ago, a script was written that was...