Joseph Brill

>[!WARNING] > Misinformation possible. The SConstruct in the fixture contains: ``` # SPDX-License-Identifier: MIT # # Copyright The SCons Foundation import os import random import sys import threading from teststate...

Seems like it would be more robust to have a loop (perhaps with a limit count) that gets a new random port and starts the server thread. Exit loop on...

Retracted: alternative solutions would better address root cause of issue. Issues possible with user additions of environment variables adding to and keeping from the msvc environment in which the msvc...

> However, keep in mind the themes in MM are custom - they are approximate and don't try to necessarily match every feature exactly. Github uses completely different rendering engine...

That looks great! > However, the colors that are actually used by GitHub don't match the colors you have in your table. I used the actual GitHub colors. Likely user...

The changes to both the light and dark themes are very well done. Kudos. > Not sure I understand this comment: > > > As a placeholder, both manual and...

The two test failures: * experimental on macos (two ninja tests that fail consistently) * appveyor (Visual Studio 2022; Environment: WINPYTHON=Python313) appears to "hang" after final test but before reporting...

The windows hang is unusual. For the experimental macos tests, these two tests seem to be virtually guaranteed to fail lately: ``` Failed the following 2 tests: test/ninja/ninja_handle_control_c_rebuild.py test/ninja/shutdown_scons_daemon.py ```...

> It's possible, of course. I've suggested it, too - would like to see a green result. On the other hand, it's a nag to look into this. Green result...

Isn't this whole PR CI related? There are modifications to two existing workflow files and one new test file.