Joseph Brill

> So there was value in supporting any tests which didn't actually require a working MSVC compiler to be able to run on any platform. There may have been some...

@mwichmann **POP QUIZ!** Tests: * /test/MSVS/vs-files.py * /test/MSVS/vs-scc-files.py * /test/MSVS/vs-scc-legacy-files.py * /test/MSVS/vs-variant_dir.py Use this logic ``` import TestSConsMSVS for vc_version in TestSConsMSVS.get_tested_proj_file_vc_versions(): test = TestSConsMSVS.TestSConsMSVS() ... test.pass_test() ``` Do you...

Excellent. (I had to put in a print statement.) It was introduced in PR #3409. Basically these four tests only run for VC 8.0 This fixes the loop issue: ```...

> see, it's better to leave tests incomplete and not slow down the development process :-) preaching to the choir!

> It seems kind of odd to put a dummy pass inside the loop. Yeah. There really is not a good reason. Originally, I didn't know if there was some...

I just added at the end of the loop: ``` del os.environ['PYTHON_ROOT'] ``` I don't think it is supposed to be defined for the initial calls of the loop.

I have a version which passes for the four tests listed when running under WSL. I need to check if any of the changes to TestSConsMSVS or Tool/msvs broke any...

> probably sufficient. Sorry for being flippant. I had already fixed that one with a one-liner before your post and was working on the GUID problem at the time. We...

@mwichmann Do you have a list of all the MS tests that failed on armv7? There may be an easy fix. Some of the MSVS test scripts explicitly set HOST_ARCH...

Guessing these are the six tests that fail: * /test/MSVS/vs-7.0-scc-files.py * /test/MSVS/vs-7.0-scc-legacy-files.py * /test/MSVS/vs-7.1-scc-files.py * /test/MSVS/vs-7.1-scc-legacy-files.py * /test/MSVS/vs-scc-files.py * /test/MSVS/vs-scc-legacy-files.py