jcavanagh

Results 5 comments of jcavanagh

I have a pending pull for this issue, should be available for review early next week.

> as it'd cause any hook to an internal call in another namespace to likely break Other k8s namespaces should work just fine, so long as they are not named...

@jasonmcintosh I've made the following changes to the implementation: - Verbatim IP addresses are now rejected by default - IP filtering is again considered against the resolved address - No...

> The description implies this, but I want to go ahead and write it out -- the idea here is that someone making calls into spinnaker itself in a webhook...

> ORIGINALLY the plan was "ok let's break this and make it a DENY ALL by default, then REQUIRE end users to whitelist any supported webhook targets". AKA you'd want...