vintage-sublime-surround icon indicating copy to clipboard operation
vintage-sublime-surround copied to clipboard

Support Vintageous

Open trkoch opened this issue 11 years ago • 9 comments

What needs to be done to make this package work with Vintageous?

For instance, this does not seem to be compatible

{"key": "vi_action", "operand": "enter_insert_mode"}

trkoch avatar Apr 27 '13 11:04 trkoch

This is what I came up with so far: https://gist.github.com/trkoch/5472771

Maybe @guillermooo can have a look?

trkoch avatar Apr 27 '13 11:04 trkoch

Hi,

I haven't tested with Vintageous yet, so thanks for the heads up and the gist. I'll take a look as soon as I get time.

jcartledge avatar Apr 29 '13 01:04 jcartledge

:+1: Would love to see this as Vintageous seems to be the Vintage successor.

jondavidjohn avatar Dec 29 '13 07:12 jondavidjohn

Thanks for your interest.

Unfortunately by the time I got around to looking at @trkoch's gist it was no longer there so I have no idea what he came up with. I haven't done anything about it myself because I'm still quite happily using ST2/Vintage, but of course I'd be thrilled if someone did the work for this :).

jcartledge avatar Dec 30 '13 05:12 jcartledge

Hi, I've been using Vintageous with this package. But it seems "s" command is still controlled by Vintageous. When I select with visual mode and press "s", the selection just disappear. Using the Command Palette shows that the Surround Selection command is bind to s indeed. Thank you.

shinglyu avatar Jan 10 '14 07:01 shinglyu

Some useful information: This is the official Vintageous plugin for surround: Vintageous_Plugin_Surround And this is a plugin which is built upon Vintageous, maybe you can see how he override Vintageous' keymap: Vintageous-Origami

shinglyu avatar Jan 10 '14 07:01 shinglyu

Correct link for the "official Vintageous plugin for surround": https://github.com/guillermooo/Vintageous_Plugin_Surround

donut avatar Jan 10 '14 16:01 donut

:+1: +1

benwoodward avatar Dec 13 '14 07:12 benwoodward

👍 +1

skube avatar Nov 03 '16 19:11 skube