Jan Bouwhuis

Results 244 comments of Jan Bouwhuis

> @jbouwh you were struggling quite a lot with this for MQTT, and it ended up with a quite complex solution IIRC. Does the proposal in this PR work, or...

The MQTT integration supports reloading manual configured items via `configuration.yaml` with the new style config, so that could be an example.

> > > > @jbouwh : seems like you complete implemented your own reload service for mqtt, is that correct? Feels for me that for a simple integration one should...

> @jbouwh: I have removed this line in **init**.py from mqtt: > > ``` > # Reload the legacy yaml platform to make entities unavailable > await async_reload_integration_platforms(hass, DOMAIN, RELOADABLE_PLATFORMS)...

Looks like the line you removed can be cleaned up. It was used to disabled entities that were set up through platform set up. I can open a separte PR...

https://github.com/home-assistant/core/pull/93588

I believe there can be even more cleaned up now. I removed some more stuff.

> > #93588 > > I will do a rebase to dev after that pull has been merged. Was #93588 was merged

What I see when I test your code in my dev environment (with all sorts of test items is): ```log 2023-06-02 17:34:17.275 ERROR (MainThread) [homeassistant.config] Invalid config for [template.sensor]: required...

May be we should check if the `dir` is an the `allowlist_external_dirs`. See https://www.home-assistant.io/docs/configuration/basic/ . If the service would be called by a user, should not be allowed to access...