jbostoen comments

Results 47 comments of


                                            jbostoen

🐛 Allow setting of itop_env $_SESSION variable through switch_env parameter if $_SESSION is still empty (SF1976) (support API and CRON)

The above fix seems to work for the API. For my use case, I was able to only put the iTop application files once on my computer and run multiple...

🐛 Allow setting of itop_env $_SESSION variable through switch_env parameter if $_SESSION is still empty (SF1976) (support API and CRON)

Haven't made these kind of tests before, I'll need to look into it. Not sure at all how to write a (for Combodo) suitable test; my personal test was actually...

🐛 Allow setting of itop_env $_SESSION variable through switch_env parameter if $_SESSION is still empty (SF1976) (support API and CRON)

I really have no clue how to write those tests and add the custom database I'm afraid :|

🐛 Allow setting of itop_env $_SESSION variable through switch_env parameter if $_SESSION is still empty (SF1976) (support API and CRON)

Unfixed (just discovered): iTop's email action relies on the ITOP_DEFAULT_CONFIG_FILE parameter, which only seems to be used here: * https://github.com/Combodo/iTop/blob/7c7386afc71a9191f5fdd66888fe3ec8248ceaf0/core/email.class.inc.php#L48 * https://github.com/Combodo/iTop/blob/5f575d524a7bcc7567cbc8b904204416e9b445e3/sources/Application/Status/Status.php#L86 Why should email (and status) rely on default...

🐛 Allow setting of itop_env $_SESSION variable through switch_env parameter if $_SESSION is still empty (SF1976) (support API and CRON)

> I would deprecate the `Email::LoadConfig` method and replace this line: > > https://github.com/Combodo/iTop/blob/7c7386afc71a9191f5fdd66888fe3ec8248ceaf0/core/email.class.inc.php#L163 > > With either `self::$m_oConfig = MetaModel::GetConfig();` or even `$oConfig = MetaModel::GetConfig();`. It's even more remarkable...

🐛 Allow setting of itop_env $_SESSION variable through switch_env parameter if $_SESSION is still empty (SF1976) (support API and CRON)

Thanks for the very quick fix!

🐛 Allow setting of itop_env $_SESSION variable through switch_env parameter if $_SESSION is still empty (SF1976) (support API and CRON)

Now that the mail issue has been addressed... Any ideas on how to get this approved? Basically environments are somewhat supported in iTop; this PR addresses some flaws in their...

🐛 Allow setting of itop_env $_SESSION variable through switch_env parameter if $_SESSION is still empty (SF1976) (support API and CRON)

> I would fix the merge conflicts first 😉 I'm going to wait on the feedback first before I spend time doing so. 😂

:globe_with_meridians: N°5390 - Update german translations for OAuth client module

On a related note, the class name's English translation is inconsistent with other occurrences where O**A**uth is used. `'Class:OAuthClient' => 'Oauth Client',`

N°4703 - Add "chat" / "in person" as possible "origin" value for tickets

"in person" is one I've added long time ago ( https://github.com/jbostoen/iTop-custom-extensions/blob/e533b458b4b25ce2a03dd99780ab85bcccc587cd/web/extensions/jb-tweaks-request-mgmt-itil/datamodel.jb-tweaks-request-mgmt-itil.xml#L49 ) Perhaps also consider adding "monitoring"? It's perhaps a bit vague, but so is chat. The basic idea is...