Josh Berdine

Results 139 comments of Josh Berdine

I expect we will need some changes due to opaque pointers becoming mandatory. IIRC there were some issues with pathological compilation times due to inlining going crazy with later versions.

Just in case it isn't already clear, note that uses of `|>` aren't going to provide representative tests of the possible breakage for general higher-order usage. Since https://github.com/ocaml/ocaml/pull/10081, `|>` type-checks...

Regarding the question of what API breakage can result from adding an optional argument, I don't know that there is a short and clear answer. Enabling warning 48 [eliminated-optional-arguments] can...

For info, I am also having trouble with the width of the ligatures in the modularspaced version: versus

Those screenshots are of Emacs: GNU Emacs 30.2 (build 2, aarch64-apple-darwin24.6.0, NS appkit-2575.70 Version 15.6 (Build 24G84)) the [emacs-plus](https://github.com/d12frosted/homebrew-emacs-plus) packaging, using the macOS native text rendering. One curiousity that might...

Maybe easier, this reproduces with plain TextEdit (on macOS 15.7.2):

Wow, I wonder what is different about my system. Ok, nothing you can do though. I guess this is my vote to put these ligatures in an opentype feature though.

I think I have understood the reason for the first point I mentioned. There are some codepoints that are only in a variant other than Regular, and my editor hunted...

I think that there are also a few corners that we will need to be careful of. For example the type definition in `skiplang/prelude/src/native/StringIterator.sk` needs to be kept in sync...