Josh Berdine

Results 139 comments of Josh Berdine

FWIW, so far my attempts to rewrite this using the isomorphism between `EHandle[], LHandle[]` and `(EHandle | LHandle)[]` have failed. I have been able to get examples to type-check, but...

Just for clarity, this is just one approach, and there is at least one more that I will investigate. So definitely don't spend any great amount of time reviewing this.

> I think we can close this. @skiplabsdaniel has a more flexible approach that seems to make TS type-inference happy. Yes, agreed. I think there is still the question of...

FWIW, I have been using this PR with ghostty without issue.

There isn't anything to prevent an ephemeron being included in the `ephe_ref_table` multiple times, so I think it is expected for [that line](https://github.com/ocaml/ocaml/blob/64ef2d0ce1eb7d5f09ac6cde1a78f74b62804cc6/runtime/minor_gc.c#L761) of `ephe_clean_minor` to run potentially multiple times....

The side-effects of `Format.pp_set_formatter_out_functions` are not synchronized with the time when the printing functions are actually called as strongly as your code would require. The queue internal to `Format` can...

Yes, the state of the out functions and the formatting queue are not correlated internally, so the only reliable points to make such changes is immediately following a flush. One...

> I added a [quick start](https://erratique.ch/software/uuidm/doc/#quick) with various example and notably how to use `v7_monotonic_gen` with `Unix.gettimeofday` and `Unix.sleepf` to get monotonic (up to gettimeofday(2) not going backwards…) time-based generation....

AFAIU comments are the one main point* that stands between really slick interop between refmt and ocamlformat that would allow seamless translation between concrete syntaxes. The heuristics for associating comments...

I'd like to understand better. Is there some reason not to make EagerCollection and LazyCollection into classes? Then they can have static methods, right? Or is that not enough?