Jeff Bencin
Jeff Bencin
Also, check that duplicate signer produces identical signatures, and recovered pubkeys are the same. This is expected because we derive the ECDSA nonce from the message hash instead of an...
Don't forget to update `package.rust-version` to `1.80` in Cargo.toml files where `LazyLock` is used
> Remove the `asm` feature from the `sha2` crate. It didn't appear to be used anywhere. > Found #4435, but didn't add much color as to why `sha2-asm` needs to...
I'm looking at the `speedy` docs and it looks like the purpose of this crate to read/write to a buffer with as little overhead as possible. Does it contain any...
> I'd be more than happy to add a bench and test suite for adding/removing/reordering There are some nice benchmarks of Rust serialization frameworks [here](https://github.com/djkoloski/rust_serialization_benchmark). Both are similar in performance,...
My thoughts after looking at the check-checker code... ### How "Check checker" Works `CheckChecker` implements the `ASTVisitor` trait. Using `ASTVisitor` allows an external function to walk the AST, and `CheckChecker`...
> how about conventions about constants for errors: Another related lint: If you have two error constants with the same value (real example I just found in my own code):...
Another one I just encountered where a lint would have been helpful: Unnecessary `as-max-len?`, where the length of the buffer returned is the same as the input buffer
I ran into this today, and I'm not sure if it should be a lint or fixed at the VM level. Apparently it's legal to do `is-eq` with a single...