Jeff Bencin

Results 73 comments of Jeff Bencin

@wileyj It's not high priority, you can ignore it for now, I just had some time to kill today while waiting on other things. But it's not a big PR...

> To verify previous signatures the process would be more complex, we would need the path, and the presig-hash previous signer used, This could be done if we could recover...

> Could you please include Zemu tests with test vectors? Will work on this. Is there a document describing how to do this, or some example in the repo I...

Hey @neithanmo I rebased this onto the latest `main`. Right now there's only one minor issue that I'm aware of: - 3 of the `make zemu_tests` tests fail because the...

I've fixed the `make zemu_test` target by updating the screenshots, so all of those tests are passing now, and the tests further down the pipeline should run next time CI...

> @jbencin First update deps/ledger-zxlib to tag V20.0.0 commit and push it so we can run CI jobs again I tried this and now `make zemu_test` fails: ``` Test Suites:...

Hey @neithanmo we have merged @fess-v's PR stacks-network/stacks-core#3710 which allows for order-independent multisig. This will be activated upon Epoch 3.0 (in the next couple months). Since this PR also adds...

@neithanmo Added test for order-independent multisig in `standard.test.ts` and verified that it produces valid signatures (both in the unit test, and using `stacks-inspect decode-tx` to check against blockchain code). This...

CI is still failing, but the same steps fail on `main` also: ![image](https://github.com/Zondax/ledger-stacks/assets/4306391/2468b05d-bbad-4a55-9f43-a3945c36d75c) I don't know what's causing it, but I don't think it makes sense to try and fix...

It's possible that my PR fixes this, as there were general issues with signing multisig transactions after the first signer. But if there is some bug with the Ledger handling...