Jesse Beder
Jesse Beder
Out of curiosity, why isn't this broken in the continuous build on Windows/shared? (see, e.g., [this run](https://github.com/jbeder/yaml-cpp/runs/6195058036?check_suite_focus=true))
This is kind of an auxiliary issue, I think, but I'd accept a PR into the /contrib folder if someone wants to write one or clean up the SO post.
This sounds reasonable to me, but I've been bitten quite a bit lately by approving CMake changes I don't understand. Could you add a clause to the github action [here](https://github.com/jbeder/yaml-cpp/blob/master/.github/workflows/build.yml)...
You know what, this is fine; if it breaks someone's build then I guess I can ask them to write a test.
@yyh-graphsql could you give a minimal example? Also, make sure you're at HEAD, since the code no longer uses boost.
Can you provide your full command line, and OS and version, etc.?
Wow, that's definitely a bug. I don't quite follow your reasoning, but if you can send a PR, I'll review it.
Yeah, this seems reasonable, I'd accept a PR.
Is there a PR to fix this? If so, I'll review it. But it's totally not worth it to spam with a bunch of compiler-specific declarations just to fix a...
To answer questions from @olafmandel above: > do they want to fill the code with such preprocessor-macros Ideally, no. > or do they want to remove the -Weffc++ compiler flag...