John Bampton comments

Results 218 comments of


                                            John Bampton

wrangler dev fetch service from localhost

When you run `wrangler dev` the code actually runs on the Cloudflare network and not on your local machine. So the Cloudflare network would have access to AWS but not...

refactor: standardize the HTML, CSS and JSP in the webapps folder.

Hey @kkolinko I removed the `br` tags and also closed the `option` tags now. I also validated the 'error.html' by direct upload and it validates now. https://validator.w3.org/#validate_by_input

refactor: standardize the HTML, CSS and JSP in the webapps folder.

> error.html: > > 1. Shouldn't it better be 2. Options shall be closed with . The s there are out of place and ignored. (validator.w3.org complains) MDN says ->...

[WIP] - feat(CI): add a GitHub action to lint the Markdown and YAML files.

Hey @martin-g I have moved both config files to the `.github` folder. If we put them in the `.github/workflows/` folder, GitHub will think they are both workflows.

[WIP] - feat(CI): add a GitHub action to lint the Markdown and YAML files.

Hey @markt-asf what do you think about this PR ?

[WIP] - feat(CI): add a GitHub action to lint the Markdown and YAML files.

Hey @markt-asf I have rebased and moved the two config files back to the repo root. The 2 files are not specific to GitHub so say we moved to GitLab...

Broken link in the "About" section

Hey @thinkerou can you please fix this link 👍

Broken link in README to 'install-info'

Error on the Debian site from this link:

Possible spelling mistakes from `codespell`

Most use `codespell` with a small custom dictionary / ignore list and you can even ignore files/folders.

[WIP] - feat(CI): add a GitHub Action to check Markdown links

Looks like we are getting rate limited by GitHub with the `Status: 429` on `github.com` links. I think this won't happen on normal PRs when we just check modified files...