Jenna Badanowski
Jenna Badanowski
Medium buttons (orange) do not meet 4.5:1 color contrast standards as well. Medium: insufficient color contrast of 3.03 (foreground color: #e9730c, background color: #ffffff, font size: 10.5pt, font weight: normal)....
@eboyer To not duplicate effort, there are a couple a11y issues in the markup of the components that have been identified in this list: https://github.com/SAP/fundamental-react/wiki/Topics-for-Fiori-Fundamentals
Related to #1346, #1348, #1349, #1350, #1351, #1352, #1353, #1354
@eboyer yeah! I'm working on a spike right now to figure out how we want to address this.
As a followup, let's cleanup all the errors about `act` and warnings too
I think I shouldn't have moved this one - oops!
List: navigable via arrow keys - look at ComboBox dropdown
Rework into separate subcomponents - see List: https://github.com/SAP/fundamental-react/tree/master/src/List ie: ``` ... .... ```
Related to https://github.com/SAP/fundamental-react/issues/969
@praneybehl We (speaking for @droshev here too) found the 🐛 for our implementation at least - it ended up being something in our `.gitignore` triggering this line: https://github.com/conventional-changelog/standard-version/blob/master/lib/lifecycles/bump.js#L155 See https://github.com/SAP/fundamental-styles/pull/1289...