Ben Mackay
Ben Mackay
- [x] `VF` - [x] `IF` - [x] `IFH` - [x] `IJF` - [x] `IJFH` - [x] `VIFH` - [x] `VIJFH` - [x] `IJKFVH`
@simonbyrne is this all sensible?
https://github.com/CliMA/ClimaCore.jl/blob/5540fc43fc00819d0c21fdbb102d9986191dd2a4/test/DataLayouts/data1d.jl#L114-L117 This does not make sense - `data1` and `data2` are arrays, not `VF` structs which we are testing. The code without `@test_prop` errors. They should be replaced with `dl1,...
@sriharshakandala would you be able to help me understand/debug the errors now in `dss_2d!`?
> Maybe change the assertions to inequalities? It seems like the info necessary to compute a conservative upper bound aren't really accessible at the `DataLayout` level. I'm inclined to close...
@simonbyrne let me know if you think it makes sense to keep this as a separate module or if we want to move this code to `src/Operators`.