jazz

jazz copied to clipboard

catch errors and log a stack trace

3

currently, we have try-catch. https://github.com/foundpatterns/torchbear/blob/2b7737008f925b793dff466dbdd508ece9baacf5/src/managers/web_server.lua#L8-L21 if we https://github.com/kyren/rlua/issues/88 , we can get a stack trace. error message can go in `log.error()`.

naturallymitchell

which functional operation would simplify this?

2

https://github.com/foundpatterns/torchbear/blob/2b7737008f925b793dff466dbdd508ece9baacf5/src/managers/web_server.lua#L11

naturallymitchell

can this move to lighttouch-libs/prelude.lua?

2

https://github.com/foundpatterns/torchbear/blob/2b7737008f925b793dff466dbdd508ece9baacf5/src/managers/web_server.lua#L4:7

naturallymitchell

Why does web server handler call request and body separately?

1

https://github.com/foundpatterns/torchbear/blob/2b7737008f925b793dff466dbdd508ece9baacf5/src/bindings/server.rs#L92

naturallymitchell

Move lighttouch stuff to lighttouch

4

~~~ events["incoming_request_received"]:trigger(request) for k, v in pairs(rules) do v.rule(request, events) end ~~~

Arnaz87

Which package to be required should be configurable

3

I think the specified package should return a function which accepts the request as an argument and returns the response

Arnaz87

names

1

event: request_process -> request_received https://www.drupal.org/project/drupal/issues/1677052#comment-6679754

naturallymitchell

tar bindings

1

https://github.com/alexcrichton/tar-rs (mostly untar, not create)

naturallymitchell

Tera error handling

5

[Tera](https://github.com/Keats/tera) can do so much more all we have now is "Failed to render template [name]."

naturallymitchell

scl.from_table() fails

3

```lua local inspect = require ("inspect") tbl = (inspect(torchbear.settings)) print(tbl) ytbl = yaml.from_table(tbl) print(ytbl) stbl = scl.from_table(tbl) print(stbl) ``` gives ``` { init = "init.lua" } --- "{\n init =...

naturallymitchell