jazz icon indicating copy to clipboard operation
jazz copied to clipboard

catch errors and log a stack trace

Open naturallymitchell opened this issue 6 years ago • 3 comments

currently, we have try-catch. https://github.com/foundpatterns/torchbear/blob/2b7737008f925b793dff466dbdd508ece9baacf5/src/managers/web_server.lua#L8-L21

if we https://github.com/kyren/rlua/issues/88 , we can get a stack trace.

error message can go in log.error().

naturallymitchell avatar Oct 15 '18 07:10 naturallymitchell

@Arnaz87 anything left here?

naturallymitchell avatar Nov 08 '18 00:11 naturallymitchell

fixed at some point, by using xpcall in here and here

Arnaz87 avatar Nov 08 '18 19:11 Arnaz87

:+1:

naturallymitchell avatar Nov 08 '18 19:11 naturallymitchell