Jay Faulkner

Results 40 comments of Jay Faulkner
trafficstars

I don't understand why the bot doesn't think I did a GCO... maybe the amended commit confused it?

Thanks for the review; I'll look over and correct the issues soon.

Whoops; forgot to fill in a description here -- apologies. Will do that now.

Hey Chris, thanks for filing the issue and coming by. Can you help us understand what is meant by a neutral github organization, and give us a pointer to the...

The nature of this PR has to change, due to how the behavior has been restructured. Now, the implementation will be across multiple PRs: - This one, which now adds...

Putting credentials in the general job flow for GHA is problematic, as those credentials can be trivially exfiltrated. Even a step beyond this; you literally *are not permitted access* to...

This LGTM, but I should not approve lookout frontend code as I'm not really qualified to.

Yeah; I used the existing docs for building this for linux. It appears to build and run properly, I can run various commands, but only when I run `nbfc config`...

`[01:50:13][W][http_request:093]: HTTP Request failed; URL: http://hw.airgradient.com/sensors/airgradient:84fce60bee00/measures; Code: 400; Duration: 1185 ms`

I got my tabs mixed up, somehow thought I was looking at your code there. I may add support for this :). Sorry for the noise!