Phil Dibowitz

Results 436 comments of Phil Dibowitz

OK, yeah that makes sense. But lets: 1. Keep the hard-coded tests for `winrm` and `ssh`, those should work fine without the gemspec mocks 2. For the dynamic test, do...

@tecracer-theinen - any update here? If we can get those last bit done, we can merge and backport.

I'm good with the changes, but this needs a rebase (for all the buildkite tests) and a sign-off (DCO) please

Sorry I never responded to this. My guess is we'll have to do some extra work to support interaction-required key-storage. I would have thought that the agent would sorta handle...

This is especially problematic for `authorized_keys`. I wanted to do: ``` authorized_keys 'c:\ssh\authorized_keys\%u' ``` translates to a thing that doesn't exist which is frustrating.

Always. Even if you're not in a domain you get `COMPUTERNAME\user`. My AD-ified machines only have a single domain.

@Toretu interesting, that doesn't seem to work for authorized_keys paths.

I did. Given `authorized_keys 'c:\ssh\authorized_keys\%u'` it looks like it should work, the logs show `C:\ssh\authorized_keys\DOMAIN\user` but creating files in that directory don't actually work, it says they're not there.

So to be clear @mtkraai - the "domain\user" gets translated into a _directory_ for the domain and then the users are files in that directory? That's what I would expect,...

Yeah the permissions were correct. You could see it trying to open a file called `domain\user` which didn't work. It sounds like this is fixed.