Javan Makhmali

Results 20 comments of Javan Makhmali

Out of curiosity, are there browsers with Shadow DOM support that don't support ``?

Thanks for the report! Showing and hiding content is implemented with CSS: https://github.com/javan/details-element-polyfill/blob/0f1404bcb46e14134b884a40c6b1d22b54b7f7bf/src/styles.js#L5-L7 Since CSS can only target element nodes, the polyfill would need to wrap all text nodes in...

Hi! :) Would https://github.com/javan/form-request-submit-polyfill/pull/4 (or a similar implementation) solve this issue by preventing item 2 in your list from happening?

This could potentially be fixed in Rails too by changing its assumption that the clicked submit button is still connected: ```diff --- a/activestorage/app/javascript/activestorage/ujs.js +++ b/activestorage/app/javascript/activestorage/ujs.js @@ -58,7 +58,11 @@ function...

> But since this deviates from then native `requestSubmit` behavior, it seems to me it should be ideally fixed on the polyfill side. The only functional difference is that the...

Support for right-alignment along with viewport overlap detection is something I'd like to add. I'm not sure when I'll get to it though.

Send a pull request! http://help.github.com/send-pull-requests/ :)

Seeing the same issue here on macOS 10.13.4 ```sh [91025:0508/094741.152446:ERROR:CONSOLE(1609)] "Loading render modules failed", source: chrome-extension://devtron/out/index.js (1609) [91025:0508/094741.152538:ERROR:CONSOLE(1610)] "RangeError: Maximum call stack size exceeded at Array.map () at walkModule (:20:35)...

> I may also be able to get some assistance from a designer/front-end dev Feel free to use Pow's templates: https://github.com/basecamp/pow/tree/master/src/templates/http_server

Excellent investigation, @ilias-t! I can verify and help illustrate your findings. The reports below show the the target ranges mapped to their nodes and offsets: ✅ Safari: https://input-inspector.now.sh/profiles/3fzHxqIH4pi8ZxqswhbO ![Screen Shot...