javaDeveloperKid

AnnotationToAttributeRector for ParamConverter is buggy

11

AnnotationToAttributeRector for SensioFrameworkExtraBundle's ParamConverter is buggy. This is what happens to me ```diff - @ParamConverter(name="parametername", class="App\Entity\MyEntity", options={"id"="identifier"}) + #[ParamConverter(name: 'parametername', class: 'App\Entity\MyEntity', options: ['id' => 'identifier'])] ``` The Symfony docs...

Can we block these requests?

1

Can we block these or this repo's functionality is just informational?

GetToConstructorInjectionRector

5

# Bug Report | Subject | Details | | :------------- | :---------------------------------------------------------------| | Rector version | e.g. v0.13.10 (invoke `vendor/bin/rector --version`) | Current behaviour of GetToConstructorInjectionRector is that it creates...

### Description Let's consider this example: ```yaml services: App\: resource: '../src/*' exclude: '../src/{DependencyInjection,Entity,Migrations,Tests,Kernel.php}' ``` All the classes in src/ **are available** as services and this is nice because we get...

Where is changelog?

4

I can't find any changelog file, any upgrade file. Release notes are very little. This package has 9 major versions so there must have been at least 9 BC breaks....

Redefinition of parameters not detected by PHPStan

5

# Bug report ### Code snippet that reproduces the problem https://phpstan.org/r/8d87b892-e2ac-4431-afb4-8635ba6f338e ### Expected output ### Did PHPStan help you today? Did it make you happy in any way? No, it...

# Bug Report This implementation https://github.com/rectorphp/rector-symfony/blob/main/src/Rector/ClassMethod/ResponseReturnTypeControllerActionRector.php is too generic. It adds Response return type without any check - controller action may not return instance of Response because uses kernel.view mechanism...

Implement ParametersRedefinitionRule. PR follow of https://github.com/phpstan/phpstan/issues/8025 Ondrej's hints from the issue comment: - [ ] Research what PHP version considers this as an error. I remember a situation that such...

AddRouteAnnotationRector adds @Route when previous annotation is invalid

3

Consider this example: ```php /** * @ParamConverter("param", class="App\MyEntity")) * @Route("/some-route", name="some_name") */ ``` AddRouteAnnotationRector results in: ```php /** * @ParamConverter("param", class="App\MyEntity")) * @Route("/some-route", name="some_name") * @Route("/some-route", name="some_name") */ ``` `@ParamConverter`...

AddRouteAnnotationRector does not add multiple @Route

6

Consider this example: ```yaml route_name: path: /some-path defaults: { _controller: 'MyBundle:Customer:edit' } route_name_2: path: /some-path # same path defaults: { _controller: 'MyBundle:Customer:edit' } # same defaults ``` AddRouteAnnotationRector results in...