Sen Yang comments

Results 70 comments of


                                            Sen Yang

JSX 2.0

@syranide It would be better if it could be solved in syntax level.

documents need to be improved to match this library's value

@jeoy good catch, thx

Bug when re-rendering occurs while mouse is pressed

Awesome! Really appreciate your effort @aduggleby

Bug when re-rendering occurs while mouse is pressed

I'm really sorry, work has been busy these days, will merge ASAP.

direction="vertical" on <Sortable> not working and <Sortable> in overflow:scroll buggy?

By 'not working' do you mean the items cannot be dragged or cannot be dropped or both? is there any error in console? Which version of this library are you...

direction="vertical" on <Sortable> not working and <Sortable> in overflow:scroll buggy?

Interesting, I'll definitely give a try.

direction="vertical" on <Sortable> not working and <Sortable> in overflow:scroll buggy?

I believe it's the correct behaviour now because IIRC I didn't deal with scrolling situation particularly 😅 But it should be fixed.

direction="vertical" on <Sortable> not working and <Sortable> in overflow:scroll buggy?

Sorry guys, kinda busy this week, I'll try to solve this during this weekend.

Maybe translate3d() has better performance than simple position right?

It is better indeed, this repo was built under the consideration of legacy browser support, so I choose `setTimeout`. You're very welcome to send some PRs to make it happen.

The animate() function still running after component unmount

Hmm, I did clear the timeout when unmount, not sure why it still fired. https://github.com/jasonslyvia/react-marquee/blob/eba231a4db3674a4dae653106a13117fa85658e5/src/index.js#L52