Jason Hansen
Jason Hansen
#68 updated the `inferno` version, which should give improved demangling of Rust symbols. This issue can probably be closed.
I think we should be able to remove `symbolic_demangle` as a dependency. #133 and #134 added to our collapsers the ability to fix partially demangled Rust symbols with no external...
Now we're down to 109 dependencies after #144. ```Console $ cargo tree --no-indent | sed 's/ (\*)//' | sort -u | wc -l 109 ```
#145, #146, and #147 have reduced dependencies further and made more of them optional. ```Console $ cargo tree --no-indent | sed 's/ (\*)//' | sort -u | wc -l 107...
As for the assertion in `perf.rs`, we could replace it with something like this: ```Rust if self.event_filter.is_none() { return Err(io::Error::new( io::ErrorKind::InvalidData, "no event filter found while processing input", )); }...
In `dtrace.rs` maybe we should check if the stack is empty at the beginning of `on_stack_end` and log a warning with an early return? So something like this: ```Rust if...
As a start to this, I profiled and generated a flame graph of running `inferno-flamegraph` with `--reverse` to create many frames. It looks like a lot of time is spent...
`svg::write_str` wasn't reusing a cached `svg::Event` like everything else. I submitted #108 to fix this.
Yes, I think so, but I'm not sure what we should do to improve it. Even though `dtoa` would be faster, I don't think it will allow us to format...
It probably doesn't really matter if we truncate instead of round. It will slightly diverge in behavior from the Perl version, but if the performance increase is large enough, I'd...