jasonphillips

Results 43 comments of jasonphillips

I'd like more information on this, since I don't presently have a good test environment locally for Android. Do you experience the same problems with the core draft-Js-plugins examples (https://github.com/draft-js-plugins/draft-js-plugins)...

Since this requires using a custom blockRenderMap, it currently depends on https://github.com/draft-js-plugins/draft-js-plugins/issues/281 -- hopefully we can get the plugins system to accept block types from plugins without manual override.

I've updated this PR to switch over from the older redux style of implementing selectors to the newer `useSyncExternalStore()` hooks provided officially as a shim and in later react versions;...

> iiuc this uses both context and passing props down below the context I can certainly answer this part. In this case the context isn’t used at all for sending...

> @jasonphillips you're using the `use-sync-external-store` approach here to resolve the problem that React currently has with not having a way to avoid unnecessary context-triggered re-renders right? So once that...

> I was looking for something like that to solve some performance issues that I have with decorators. What is preventing it to be merged? Are your performance issues happening...

> Exactly, I have a decorator that changes very frequently and it affects only a few components but it should not be rerendering everything. This PR is an improvement over...

Okay, I've rebased this and have deployed it on a version of our own application in the meantime to test a bit further. > @jasonphillips Thanks for this PR. My...

@nemanja-tosic I think this helps to push things forward quite a bit, thanks. I was letting this PR stagnate, partly because the decorations topic is so tricky and it's hard...

@MattIPv4 I'll find some time for this over the next few days, to try and more fully evaluate the performance piece by adding additional tests @nemanja-tosic suggested above. I feel...