Jason
Whoops mis-read this... yeah need to loop over the secret backends to do this.
Going to ask: SHOULD the operator be moved to the spinnaker project instead of the armory project as part of this?
> > Going to ask: SHOULD the operator be moved to the spinnaker project instead of the armory project as part of this? > > I think that probably makes...
Really needed some tests for this ;) I like the idea, and it's similar to the skip downstream flag, though operates differently from what I can see.
Be nice to get some MockWebServer classes to test these at some point... :P NOT sure if that's viable here.
Curious on the places you've found that don't handle async reads after writes. I know the correlation ids are one we hit. Our solution was to modify those to "ignore...
Note assuming merge... we'll want to call out this change in release notes, as it'd cause any hook to an internal call in another namespace to likely break. Can ALSO...
@dbyron-sf or @kskewes-sf FYI on this one...
ORIGINALLY the plan was "ok let's break this and make it a DENY ALL by default, then REQUIRE end users to whitelist any supported webhook targets". AKA you'd want to...