orca icon indicating copy to clipboard operation
orca copied to clipboard

feat(child pipeline executions): Add support for omit other stages fr…

Open Avi1235 opened this issue 2 years ago • 4 comments

This PR introduces a feature flag isolatedStreamExecution that can be defined in Run Pipeline stage. You can enable it via stage or in orca config stages.pipeline.defaultIsolatedStreamExecution by enabling it, clears all the info that other stages ran on the parent pipeline in the child - trigger.parentExecution values.

PR's related: 3989 4080

issue related 6159

For testing i ran the next pipeline: pipeline stage(trigger son-1) -> manual judgment -> pipeline stage(trigger son-2) -> manual judgment -> pipeline stage(trigger son-3) The childs(son 1/2/3): only had a wait stage

the body of the last pipeline stage increments due to keeping track of the stages that ran before and created outputs, task etc. Screen Shot 2022-09-27 at 8 55 44 AM

tests after enabling isolatedStreamExecution: true Screen Shot 2022-09-27 at 8 59 14 AM

Avi1235 avatar Sep 28 '22 16:09 Avi1235

We face some issues about huge contexts in our pipeline executions and this would be a BIG step forward to address it. Is there any ETA planned to merge this into the code base? 🙏🏻

vjda avatar Sep 14 '23 10:09 vjda

Maybe ask in spinnaker slack channel, there shouldnt be any problem merging this as it can be tuner on and off with the flag

Avi1235 avatar Oct 20 '23 00:10 Avi1235

Really needed some tests for this ;) I like the idea, and it's similar to the skip downstream flag, though operates differently from what I can see.

jasonmcintosh avatar Oct 24 '23 15:10 jasonmcintosh

Ran the workflows please 🙏 , i added a test which proves the child pipeline is isolated only having record of one stage from his parentExecution

Avi1235 avatar Dec 21 '23 17:12 Avi1235

Closing since https://github.com/spinnaker/orca/pull/4620 i believe addresses huge pipelines bodies

Avi1235 avatar Jun 04 '24 04:06 Avi1235