jasonjunweilyu

Results 5 comments of jasonjunweilyu

Hi @MatthewHambley , thanks for the review. I would second @hiker's opinions. For me, implementing this with a callback function would have the following benefits: (1) Matching the current LFRic...

This is addressed by PR #425 . So I have linked in this PR.

This is the current way of how LFRic makefiles do compiler version comparison. I have converted this into Python: ``` compiler_version_comparison = ''.join(f"{int(version_component):02d}" for version_component in compiler.get_version().split('.')) if compiler_version_comparison >=...

I tried to add error capturing to the `compile_fortran` step `def compile_file` function that calls the compiler `compile_file` function, as is shown below. This does not seem to work looking...

I believe the psyclone step now already supports incremental builds with prebuild hash calculations: https://github.com/MetOffice/fab/blob/03422d7e4ecfbe71bb7ccbe969631a95219f2d1f/source/fab/steps/psyclone.py#L348 The hash includes the x90 file hash, the kernel hashes, the transformation script hash, the...