Jason Ish

Results 102 comments of Jason Ish

Maybe just use `mime.rs` in `src/` until the mime module needs multiple files?

> > Maybe just use `mime.rs` in `src/` until the mime module needs multiple files? > > The file is already there, so I did not move it ;-) So...

I've pushed some changes to better show what I was heading towards with this work. With this PR if you provide a minimal configuraition like: ``` %YAML 1.1 --- outputs:...

> Nice! Any thoughts on how to make sure any built-in default goes through the proper API? Sort of. There is no way to enforce it of course, but we...

> Loosely related question : I am getting a bit confused about `outputs.0.eve-log = enabled` when I read in the yaml `outputs.eve-log = enabled` > > How does it get...

> Are there more config options to test ? Some that might be harder to test? Napatech, PF_RING, and DAG support? We seem good for NF_QUEUE now tho.

> > > Are there more config options to test ? > > > > > > Some that might be harder to test? Napatech, PF_RING, and DAG support? >...

> Can we add these options like pfring in CI ? It would be possible to add PF_RING, but not Napatech or DAG as those are closed libraries.

Thanks @shizishizi2012. Can you please elaborate in the git commit why they copy is not needed? Thanks!

> @jasonish the end goal is to have libhtp as a crate, right ? Yes, that would be ideal. Might require some hand maintenance of header files for the C...