Jason Ian Green
Jason Ian Green
If you don't have time @irskep I'm keen to help out, but you'd have to add me as an npm collaborator for this project.
Here I am https://www.npmjs.com/~jason-green On Mon, 5 Nov 2018, 03:28 Steve Landey What's your npm username? > > — > You are receiving this because you authored the thread. >...
I think we did this, but I don't want to close it without being sure as to what it was referring.
Yeah, I have been looking at it this morning.Should there not just be a different method for `Facet$check` to use which simply adds the facets to the component config... but...
It looks like it could one day be a source of trouble, look at all the places we use it. You can search the project for `require: ['`
Maybe the last, given that it would more or less be an internal method, not used elsewhere. I had thought of the others too. I don't mind 2 either.
Maybe it should just fire warnings for the requires.
Even the `facent._started` idea is not so simple to implement because it needs to be checked in `allFacets`. I got it working by adding something horrible like this: `!facet['_'+method+'ed']`
Yeah, agreed.