Jason comments

Results 113 comments of


                                            Jason

trafficstars

Remove NPM ShellJS and use Node's child_process.execSync

If we're able to switch entirely to this built in module, then we remove one dependency, which is nice. But we may be using ShellJS' features that make it easier/cleaner...

Move examples to snarkyjs repo and pull from there instead of zkapp-cli

Reviewing with Yoni. We don't think the benefits outweigh the costs and want to close to clean up repo for now

Add more robust validation to the deploy URL user input on config step

Reviewing with Yoni. We're aligned to close this because doesn't seem necessary

List example projects and let user select them in the CLI

Reviewing with Yoni. We'd like to define this issue as a dropdown list that we define & update manually, rather than an HTTP request to Github which involves latency.

Add Github Actions workflow to build & deploy a user's project to NPM

Reviewed with Yoni. Keeping open and adding `to-research`

Require tests to pass before committing OR add directions to README for devs to add it optionally

Discussed with Yoni. Closing for now because maybe too opinionated.

Add `check` command

Closing to clean up. Not realistic that we prioritize this anytime soon. Need for it hasn't been seen in practice yet

Handle cases where `config.json` is either empty or malformed.

@MartinMinkov Reviewing issues with Yoni. I recall this was surfaced during a code review. But we haven't encountered this in the real world ever have we? If so, would consider...

Handle cases where `config.json` is either empty or malformed.

@mitschabaude Doing that, the dev will also create the potential for conflicts within their `keys` directory. While I'd be okay supporting the ability to delete the config file to start...

Discussion: Should the project template be a clone of a repo on Github?

Discussed with Yoni. Gittar has been working well, and we don't want to make this large of a change